bug#50869: 28.0.50; tramp: void-function tramp-file-name-method--cmacro

[Lars Ingebrigtsen]

Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> writes:

> The main point is that putting the `cl-defstruct` into the
> `tramp-loaddefs.el` is really ugly and I think it's asking for trouble.

The cl-defstruct is in there because a couple of defsubsts (that use the
struct) are also in the tramp-loaddefs.el file.  So if we remove the
defstruct, we also have to adjust the defsubsts.

> In contrast the OP's "errors" aren't actual errors, they're just
> messages indicating that some optimization could not be applied.
> We should really change the wording to clarify that they're warnings.
>
> (see first hunk in patch below).

Looks good.

> - We could make `cl-defstruct` use `define-symbol-prop` rather than
>   `put`, as in the third hunk of the patch below.

Makes sense to me.