bug#50869: 28.0.50; tramp: void-function tramp-file-name-method--cmacro

[Stefan Monnier]

>> The main point is that putting the `cl-defstruct` into the
>> `tramp-loaddefs.el` is really ugly and I think it's asking for trouble.
>
> The cl-defstruct is in there because a couple of defsubsts (that use the
> struct) are also in the tramp-loaddefs.el file.  So if we remove the
> defstruct, we also have to adjust the defsubsts.

Indeed, since this bug was reported, the rest of the code has grown more
dependent on duplicating the `cl-defstruct` to `tramp-loaddefs.el`.

> Looks good.
[...]
> Makes sense to me.

Pushed to `master`.  This should fix this bug, which means we may want
to update the comment:

    ;; The basic structure for remote file names.  We must autoload it in
    ;; tramp-loaddefs.el, because some functions, which need it, wouldn't
    ;; work otherwise when unloading / reloading Tramp.  (Bug#50869)

to clarify that it's now still kept in `tramp-loaddefs` but for
other reasons.


        Stefan