[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#51384: 28.0.60; substitute-command-keys finds global binding for und
From: |
Robert Pluim |
Subject: |
bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap |
Date: |
Thu, 15 Sep 2022 09:39:43 +0200 |
>>>>> On Wed, 14 Sep 2022 20:29:52 +0200, Lars Ingebrigtsen <larsi@gnus.org>
>>>>> said:
Lars> Robert Pluim <rpluim@gmail.com> writes:
>> I have a change that will cause the lookups to happen in the specified
>> map first, but I still need to audit the 50 or so uses of a command
>> with an advertised binding in a docstring in the Emacs sources before
>> I can declare it safe.
I donʼt think any of the advertised bindings caused a problem, but
Iʼll double check.
Lars> This was more than half a year ago -- did you get any further here?
(I
Lars> agree that the explicitly specified keymap should take precedence over
Lars> :advertised-key-binding.)
The patch has shrunk in the meantime, somebody simplified the code ;-)
Robert
diff --git a/lisp/help.el b/lisp/help.el
index 15ab3192ad..263775e64e 100644
--- a/lisp/help.el
+++ b/lisp/help.el
@@ -1204,7 +1204,8 @@ substitute-command-keys
(delete-char 2)
(let* ((fun (intern (buffer-substring (point) (1- end-point))))
(key (with-current-buffer orig-buf
- (where-is-internal fun keymap t))))
+ (where-is-internal fun (ensure-list keymap)
t)))
+
(if (not key)
;; Function is not on any key.
(let ((op (point)))
- bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap, Lars Ingebrigtsen, 2022/09/14
- bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap,
Robert Pluim <=
- bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap, Lars Ingebrigtsen, 2022/09/16
- bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap, Robert Pluim, 2022/09/16
- bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap, Lars Ingebrigtsen, 2022/09/16
- bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap, Robert Pluim, 2022/09/20
- bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap, Lars Ingebrigtsen, 2022/09/20
- bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap, Robert Pluim, 2022/09/20