[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#51384: 28.0.60; substitute-command-keys finds global binding for und
From: |
Robert Pluim |
Subject: |
bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap |
Date: |
Thu, 15 Sep 2022 11:04:28 +0200 |
>>>>> On Thu, 15 Sep 2022 11:00:09 +0200, Andreas Schwab
>>>>> <schwab@linux-m68k.org> said:
Andreas> On Sep 15 2022, Robert Pluim wrote:
>>>>>>> On Thu, 15 Sep 2022 09:39:43 +0200, Robert Pluim <rpluim@gmail.com>
said:
>>
Robert> The patch has shrunk in the meantime, somebody simplified the code
;-)
>>
>> Although, apart from the patch missing a paren, it doesnʼt work,
>> because Iʼve forgotten how Lisp lists work :-)
>>
>> diff --git a/lisp/help.el b/lisp/help.el
>> index 15ab3192ad..90476e4a4f 100644
>> --- a/lisp/help.el
>> +++ b/lisp/help.el
>> @@ -1204,7 +1204,11 @@ substitute-command-keys
>> (delete-char 2)
>> (let* ((fun (intern (buffer-substring (point) (1- end-point))))
>> (key (with-current-buffer orig-buf
>> - (where-is-internal fun keymap t))))
>> + (where-is-internal fun
>> + (if keymap
>> + (list keymap)
>> + keymap)
Andreas> aka (and keymap (list keymap))
Indeed. Either too much C or not enough coffee this morning.
Robert
--
- bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap, Lars Ingebrigtsen, 2022/09/14
- bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap, Robert Pluim, 2022/09/15
- bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap, Lars Ingebrigtsen, 2022/09/16
- bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap, Robert Pluim, 2022/09/16
- bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap, Lars Ingebrigtsen, 2022/09/16
- bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap, Robert Pluim, 2022/09/20
- bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap, Lars Ingebrigtsen, 2022/09/20
- bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap, Robert Pluim, 2022/09/20
- bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap, Stefan Kangas, 2022/09/20
- bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap, Robert Pluim, 2022/09/21
- bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap, Stefan Kangas, 2022/09/21