bug#58889: 29.0.50; C-x p f on svn project fails

[Po Lu]

Dmitry Gutov <dgutov@yandex.ru> writes:

> Hi!
>
> On 30.10.2022 09:15, Po Lu via Bug reports for GNU Emacs, the Swiss
> army knife of text editors wrote:
>> Trying to navigate with C-x p f in an SVN repository fails, because the
>> SVN repository has an ignore property with empty lines.  This is the
>> detailed error.
>> Debugger entered--Lisp error: (args-out-of-range "" 0)
>>    #f(compiled-function (entry) #<bytecode -0x1726de7462823143>)("")
>>    mapcar(#f(compiled-function (entry) #<bytecode -0x1726de7462823143>) ("" 
>> ""))
>>    #f(compiled-function (project dir) #<bytecode 0x187989c589069892>)((vc 
>> SVN "~/project/") "~/project/")
>>    apply(#f(compiled-function (project dir) #<bytecode 0x187989c589069892>) 
>> (vc SVN "~/project/") "~/project/")
>>    project-ignores((vc SVN "~/project/") "~/project/")
>>    project--dir-ignores((vc SVN "~/project/") "~/project/")
>>    #f(compiled-function (dir) #<bytecode 0x68383878a42445c>)("~/project/")
>>    mapcan(#f(compiled-function (dir) #<bytecode 0x68383878a42445c>) 
>> ("~/project/"))
>>    #f(compiled-function (project &optional dirs) #<bytecode 
>> -0x1baeb702532f0340>)((vc SVN "~/project/") ("~/project/"))
>>    apply(#f(compiled-function (project &optional dirs) #<bytecode 
>> -0x1baeb702532f0340>) (vc SVN "~/project/") ("~/project/"))
>>    project-files((vc SVN "~/project/") ("~/project/"))
>>    project-find-file-in(#("Flipped90:" 0 10 (fontified t)) ("~/project/") 
>> (vc SVN "~/project/") nil)
>>    project-find-file(nil)
>>    funcall-interactively(project-find-file nil)
>>    command-execute(project-find-file)
>> Would someone please take a look at this?
>
> Does this help? I don't have an SVN repository to test.
>
> diff --git a/lisp/vc/vc-svn.el b/lisp/vc/vc-svn.el
> index 270877041a..f240ebafca 100644
> --- a/lisp/vc/vc-svn.el
> +++ b/lisp/vc/vc-svn.el
> @@ -366,7 +366,7 @@ vc-svn-ignore-completion-table
>    (with-temp-buffer
>      (when (zerop (vc-svn-command
>                    t t nil "propget" "svn:ignore" (expand-file-name
>                    directory)))
> -      (split-string (buffer-string) "\n"))))
> +      (split-string (buffer-string) "\n" t))))
>
>  (defun vc-svn-find-admin-dir (file)
>    "Return the administrative directory of FILE."

This seems to work, thanks.