[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces
From: |
Yuan Fu |
Subject: |
bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces |
Date: |
Mon, 31 Oct 2022 19:14:51 -0700 |
> On Oct 31, 2022, at 6:21 PM, Randy Taylor <dev@rjt.dev> wrote:
>
> The attached patch adds the following faces:
> • font-lock-escape-face
> • font-lock-number-face
> • font-lock-operator-face
> • font-lock-property-face
> • font-lock-punctuation-face
>
> font-lock-property-face inherits font-lock-variable-name-face which matches
> the behaviour of cc-mode and python-mode.
>
> font-lock-escape-face inherits nothing. In python-mode, it inherits
> font-lock-constant-face, but not in cc-mode. Do we want it to inherit
> anything?
>
> Hopefully I put everything in the right place.
>
> <0001-Add-more-font-lock-faces.patch>
Looks good! I would add a bit more explanation/example for
font-lock-property-face and font-lock-punctuation-face. Eg, it’s not
immediately clear to me what does preperty represent (property of an object as
in obj.prop?). And it would be nice to say that punctuation-face are for commas
and parenthesises.
Yuan