bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme'


From: Manuel Giraud
Subject: bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme'
Date: Thu, 02 Mar 2023 14:12:43 +0100
User-agent: Gnus/5.13 (Gnus v5.13)

Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Sun, 26 Feb 2023 16:33:02 +0100
>> From:  Manuel Giraud via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>> 
>> Here is a new user option to make DocView, with SVG backend, honor the
>> current theme colors.
>
> I have nothing against the feature, but wouldn't it be better to
> modify DocView to use faces for this, and then themes could override
> those faces?

Why not but I have two issues with this:

    - we had to set those new faces in every Emacs' themes and also wait
      for any theme maker to use them
      
    - those are really just two colors not real faces as the rendering
      is controlled by an external tool anyway
-- 
Manuel Giraud





reply via email to

[Prev in Thread] Current Thread [Next in Thread]