bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme'


From: Eli Zaretskii
Subject: bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme'
Date: Thu, 02 Mar 2023 18:32:09 +0200

> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: 61816@debbugs.gnu.org
> Date: Thu, 02 Mar 2023 16:51:59 +0100
> 
> Manuel Giraud <manuel@ledu-giraud.fr> writes:
> 
> > Eli Zaretskii <eliz@gnu.org> writes:
> >
> > [...]
> >
> >> You are right, of course.  It just feels strange to need to cater to
> >> themes in a core package, when the way themes are supposed to
> >> customize Emacs exists and can be used in this case as well.
> >>
> >> Alternatively, maybe themes should have settings for features such as
> >> this one?
> >
> > Maybe, we could customize doc-view-svg-\(fore\|back\)ground in the
> > official Emacs themes for a start, WDYT?
> 
> ... and in order to be able to use 'custom-theme-set-faces', we could
> have a 'doc-view-svg-face' (used only for its foreground and
> background).  I'm caching you up slowly 😅

Fine by me, that's what I proposed.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]