Re: [Bug-gnubg] Tutor mode patches for gnubg

[Joern Thyssen]

On Wed, Jul 24, 2002 at 07:25:16PM +0200, Jim Segrave wrote
> On Wed 24 Jul 2002 (16:23 +0000), Joern Thyssen wrote:
[snip]
> > I think it's vice-versa: tutor-mode uses AnalyseMove which uses
> > esAnalysisCube and esAnalysisChequer, whereas hint and eval uses esEval.
> 
> You're right.
>  
> > So tutor mode may flag a move as bad, but the hint dialog may say that
> > you're making the correct move (that actually happened to me).
> 
> And me as well. And, before I fixed it to not evaluate gnubg's
> doubling decisions, gnubg itself got a popup query for a drop :-)
> 
> > I see no problem in that. Although it might be better to use the
> > evaluation settings instead of the analysis settings?
>  
> Maybe that should be a choice - if I (or someone) adds some frills to
> selecting this mode, then one option could be to select which one to
> use. I ended up using AnalyzeMove because it was easy for me to see
> what I needed to hook this code in. I assume that I should be able to
> find what I need in CommandHint or the routines it calls as well.

We can change the prototype of AnalyzeMove to take two pointers to
evalsetups, instead of using the global variables esAnalysis*. When
called from tutor-mode we pass esEvalCube and esEvalChequer. When called
from AnalyseGame we pass esAnalysis*.

> > > This might be better, but a) I did not fancy playing with
> > > the code in gtkboard.c and b) I admit that I'm still not clear how the
> > > board makes the buttons appear and disappear (gtk_widget_hide () of
> > > the button box is not it, the board would be re-sizing if you do
> > > that).
> > 
> > It uses some GtkHButtons: takedrop, rolldouble, agreedecline, and
> > play. Check board_size_allocate, I think it does the magic. 
> > 
> > I think you could add a new GtkHButtons tutormodechequer, tutormodecube
> > etc, and just copy the magic in board_size_allocate and update_buttons.
> 
> I'm open to suggestions as to whether or not it should be on the
> board, but the more I think about it, the more I prefer a popup. I use
> a laptop with a 1024x768 screen. I lke to get the board as large as
> possible, so any border area reserved for buttons etc. is a
> limitation. I was surprised to find that I missed fewer obvious plays
> when I maximise the display. But I guess it would reuse the area that
> the Take/Drop buttons use, so maybe this is a non-issue.

Yes, I think I prefer the pop-up too, but this is a possibility.

> > > Perhaps it should allow the user to select the level at which it
> > > issues warnings (so that it wouldn't interrupt play for a 'doubtful
> > > move', only a 'bad' or 'very bad' play.
> > 
> > I agree.
> 
> It's easy to do, it mostly complicates the Settings menu itself. But
> there's lots of samples of what's needed I can use.
> 
> > > It might be desireable to allow separate selection of which types of
> > > play get watched - chequer or cube, possibly chequer, doubling and
> > > responses to doubling.
> > 
> > I agree.
> 
> OK - I'll look at what I can do to allow setting the skill level and
> which types of play to evaluate. It may be a week or two though. So if
> anyone else wants to do it, feel free.

No, go ahead :-) No rush, though.

> > I've only a played a few games with tutor mode, and I must admit I
> > really like it.  Thank you very much for the patch! I'll take the
> > liberty to commit the code to the CVS repository (and remove the auto
> > analysis).
> 
> It's hardly taking a liberty.  Also please look at the other report
> about DestroyHint() doing frees of NULL pointers - this is not an
> artefact of the tutor mode changes.

Yes, I'll look into that. It's a Good Thing we have a BSD user as well,
because apparently both Linux and Windows does memory handling
differently (although Ian Shaw has reported some mysterious seg faults
with the windows version).

Jørn

-- 
Joern Thyssen, PhD
Vendsysselgade 3, 3., DK-9000 Aalborg, Denmark
+45 9813 2791 (private) / +45 2077 2689 (mobile) / +45 9633 7036 (work)