[Bug-gnubg] Patches for go-to-next-marked

[Jim Segrave]

I've added some code to allow the game record window to have two
additonal buttons. These will move you to the next/previous marked
move in the list (if there is one). If there is no next/previous
marked move, nothing happens. 

I've added the buttons as the rightmost pair on the game list
window. They should have their own pixmaps, I simply stole the ones
used for next/previous game. I have no idea how to generate a pixmap,
but, if I did, I would duplicate the next/previous move pixmaps and
overlay a question mark over them.  

Patches are clean against a CVS update from 13:40 GMT 7 Aug.

The behaviour takes a bit of exploring (but in fact, the simple next
command/button took me minute to see what it did.

If you press the button/enter the command  'next marked', the game
window shows the next erroneous move highlighted. The board position
shown is that at the end of the move (e.g. after the player clicked
the dice to pass control to the opponent. Clicking on the move in the
game window sets the board to the position before the move and the
dice for the player appear (so chequers will appear to move).

When going backwards through the list, hitting 'previous marked' puts
the board at the state before anything has been done. Clicking on the
highlighted move makes the dice appear, but no chequers will move.

Graphically:

time  0        0.5      1     1.5     2      2.5     3      3.5   4
  opponent ends      player       player rolls   player moves   player
     move          does/doesn't      dice         chequers     picks up dice
                    double                                     ends move

Using the 'next' command/button:

1st press takes you to t = 0.5
2nd press takes you to t = 1.5
3rd press takes you to t = 0.5 of opponent's move

Using the 'next marked' command/button:

1st press takes you to t = 3.5 of a bad move
2nd press takes you to t = 3.5 of following bad move

Using the 'previous' command/button:
1st press takes you to t = 2.5 of previous move
2nd press takes you to t = 2.5 of move before that one

Using the 'previous marked' command/button:
1st press takes you to t = 0.5 of previous bad move
2nd press takes you to t = 0.5 of bad move before that one.

         
-- 
Jim Segrave           address@hidden

b1.diff.gz
Description: application/gunzip