Re: [Bug-gnulib] getline & getline_safe

[Derek Robert Price]

A divergence from the current discussion on this thread, but back to the 
original, you left out some AC_LIBOBJs from my original patch and 
changed my modules/getnline definition.

Here's why I had it right in the first place, though I am sure there are 
a few variants on working solutions:

   address@hidden ccvs-work]$ automake
   lib/Makefile.am:64: automatically discovered file `getndelim2.c' 
should not be explicitly mentioned
   address@hidden ccvs-work]$

This configuration is unfortunately necessary when both modules/getnline 
and modules/getline are used as currently defined since getline is 
attempting to compile getndelim2 conditionally and getnline has the 
getndelim2 module listed as a prerequisite.

I propose that the getnline module be modified to always require 
gl_PREREQ_GETNDELIM2 and AC_LIBOBJ([getndelim2]).

Index: modules/getnline
===================================================================
RCS file: /cvsroot/gnulib/gnulib/modules/getnline,v
retrieving revision 1.2
diff -u -r1.2 getnline
--- modules/getnline    18 Jul 2003 16:58:06 -0000      1.2
+++ modules/getnline    31 Jul 2003 17:09:34 -0000
@@ -2,8 +2,11 @@
Read a line from a stream, with bounded memory allocation.

Files:
+lib/getndelim2.h
+lib/getndelim2.c
lib/getnline.h
lib/getnline.c
+m4/getndelim2.m4
m4/getnline.m4
m4/ssize_t.m4

@@ -14,7 +17,7 @@
gl_GETNLINE

Makefile.am:
-lib_SOURCES += getnline.h getnline.c
+lib_SOURCES += getndelim2.h getnline.h getnline.c

Include:
"getnline.h"
Index: m4/getnline.m4
===================================================================
RCS file: /cvsroot/gnulib/gnulib/m4/getnline.m4,v
retrieving revision 1.2
diff -u -r1.2 getnline.m4
--- m4/getnline.m4      18 Jul 2003 16:58:06 -0000      1.2
+++ m4/getnline.m4      31 Jul 2003 17:09:34 -0000
@@ -11,5 +11,6 @@
  dnl Prerequisites of lib/getnline.h.
  AC_REQUIRE([gt_TYPE_SSIZE_T])
  dnl Prerequisites of lib/getnline.c.
-  :
+  gl_PREREQ_GETNDELIM2
+  AC_LIBOBJ(getndelim2)
])


Derek

--
               *8^)

Email: address@hidden

Get CVS support at <http://ximbiot.com>!
--
It is as useless to argue with those who have renounced the use and authority 
of reason as to administer medication to the dead.

                        - Thomas Jefferson