[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-gnulib] dos.m4 revisited

From: Jim Meyering
Subject: Re: [Bug-gnulib] dos.m4 revisited
Date: Wed, 12 May 2004 16:03:21 +0200

Derek Robert Price <address@hidden> wrote:
> Paul Eggert wrote:
>>Derek Robert Price <address@hidden> writes:
>>>both `/' and `\' are called "slashes" on most systems.  I would like
>>>to suggest that the `ISSLASH' macro be renamed `ISDIRSEP' or the like.
>>There's prececedent for that.  emacs uses IS_DIRECTORY_SEP.  GCC uses
>>IS_DIR_SEPARATOR.  On the other hand, several programs use ISSLASH as
> I just think ISDIRSEP would be clearer since a "slash" can have
> meanings other than a path element separator in other contexts, though
> I will grant there is probably rarely ambiguity in projects using GNULIB,
> Regardless, it would increase readability for people not familar with
> the code, so I will generate a patch if there is a consensus.

It'd be good to standardize the names and use of such macros.
Just yesterday I wrote code to test whether a file name
represents an absolute path name.  It would have been nice
to have a ready-made, portable macro.

I have a slight preference for IS_DIR_SEPARATOR.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]