[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Tue, 24 Jan 2006 14:15:59 +0100
Simon Josefsson <address@hidden> wrote:
>> Any objection to removing [useless parentheses]?
> No, please install them.
Ok. I've checked that in.
> I agree. I wish 'indent' could fix this
> too. Maybe it can? Even if I agree many code writing ideas given
> here, I forget them all the time.
I tend to forget, too, so have automated quite a few policy checks,
over the years. You might try adding some checks like those in coreutils'
Makefile.maint. Here are the syntax-check (sc) target names:
For example, recently I noticed a file that included assert.h, but that
didn't use assert anywhere. Obviously, it shouldn't include <assert.h>.
The above sc_prohibit_assert_without_use rule checks for that, and found
4 or 5 more offending .c files in coreutils.
If you agree with the spirit of a rule, but want to grant an exception or
two, list the offending files (or regexp) in the corresponding .x-sc-* file.
These tests are run only at `make distcheck' time, so I don't worry
much about portability to deficient versions of programs like grep.
Re: socket.h, Simon Josefsson, 2006/01/24
- Re: socket.h,
Jim Meyering <=