bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

gnulib-tool and line length: gl_LIBOBJS


From: Ralf Wildenhues
Subject: gnulib-tool and line length: gl_LIBOBJS
Date: Sun, 28 Jan 2007 13:28:23 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

The combined length of object names in gl_LIBOBJS can get pretty close
to the line limit of some 'make' implementations, or, FWIW, the portable
text file format limit.

As Autoconf 2.60 allows newlines in substituted values, there's an easy
fix for users of new Autoconf.  WDYT?

Cheers,
Ralf

2007-01-28  Ralf Wildenhues  <address@hidden>

        * gnulib-tool (func_emit_initmacro_end): If Autoconf-2.60 or
        newer is required anyway, line-wrap gl_LIBOBJS and gl_LTLIBOBJS
        to prevent exceeding portable line length limitations.

Index: gnulib-tool
===================================================================
RCS file: /cvsroot/gnulib/gnulib/gnulib-tool,v
retrieving revision 1.218
diff -u -r1.218 gnulib-tool
--- gnulib-tool 27 Jan 2007 13:53:54 -0000      1.218
+++ gnulib-tool 28 Jan 2007 12:18:21 -0000
@@ -1471,8 +1471,18 @@
   echo "      # Remove the extension."
   echo "      sed_drop_objext='s/\\.o\$//;s/\\.obj\$//'"
   echo "      for i in \`for i in \$${macro_prefix}_LIBOBJS; do echo \"\$i\"; 
done | sed \"\$sed_drop_objext\" | sort | uniq\`; do"
-  echo "        ${macro_prefix}_libobjs=\"\$${macro_prefix}_libobjs 
\$i.\$ac_objext\""
-  echo "        ${macro_prefix}_ltlibobjs=\"\$${macro_prefix}_ltlibobjs 
\$i.lo\""
+  case $autoconf_minversion in
+  2.[6-9][0-9] | [3-9].*)
+    echo "        ${macro_prefix}_libobjs=\"\$${macro_prefix}_libobjs \\\\
+ \$i.\$ac_objext\""
+    echo "        ${macro_prefix}_ltlibobjs=\"\$${macro_prefix}_ltlibobjs \\\\
+ \$i.lo\""
+    ;;
+  *)
+    echo "        ${macro_prefix}_libobjs=\"\$${macro_prefix}_libobjs 
\$i.\$ac_objext\""
+    echo "        ${macro_prefix}_ltlibobjs=\"\$${macro_prefix}_ltlibobjs 
\$i.lo\""
+    ;;
+  esac
   echo "      done"
   echo "    fi"
   echo "    AC_SUBST([${macro_prefix}_LIBOBJS], [\$${macro_prefix}_libobjs])"




reply via email to

[Prev in Thread] Current Thread [Next in Thread]