bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: expand-before-require bug


From: Jim Meyering
Subject: Re: expand-before-require bug
Date: Wed, 28 Jan 2009 14:05:12 +0100

Eric Blake <address@hidden> wrote:
...
>>From fcf62c3dfcc0a9ca32860327494e9971623f062c Mon Sep 17 00:00:00 2001
> From: Eric Blake <address@hidden>
> Date: Mon, 26 Jan 2009 09:08:48 -0700
> Subject: [PATCH] Backport improved autoconf semantics of AC_DEFUN_ONCE.
>
> * m4/00gnulib.m4: New file.

Hi Eric,

First, thanks for all your work on this.

At least autoconf-2.59 warns:

  gnulib/m4/00gnulib.m4:11: warning: underquoted definition of NAME

How about this work-around?

>From f20cf45aad2fca5726dfaeb16865f1e0903357ed Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Wed, 28 Jan 2009 14:02:54 +0100
Subject: [PATCH] 00gnulib.m4: add m4 quotes in shell comment to avoid autoconf 
warning

* m4/00gnulib.m4 (AC_DEFUN_ONCE): Add quotes to avoid an
"underquoted definition of NAME" from autoconf-2.59.
---
 m4/00gnulib.m4 |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/m4/00gnulib.m4 b/m4/00gnulib.m4
index a6b5e21..fd6071d 100644
--- a/m4/00gnulib.m4
+++ b/m4/00gnulib.m4
@@ -1,4 +1,4 @@
-# 00gnulib.m4 serial 1
+# 00gnulib.m4 serial 2
 dnl Copyright (C) 2009 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -8,7 +8,7 @@ dnl This file must be named something that sorts before all 
other
 dnl gnulib-provided .m4 files.  It is needed until such time as we can
 dnl assume Autoconf 2.64, with its improved AC_DEFUN_ONCE semantics.

-# AC_DEFUN_ONCE(NAME, VALUE)
+# AC_DEFUN_ONCE([NAME], VALUE)
 # --------------------------
 # Define NAME to expand to VALUE on the first use (whether by direct
 # expansion, or by AC_REQUIRE), and to nothing on all subsequent uses.
--
1.6.1.1.374.g0d9d7




reply via email to

[Prev in Thread] Current Thread [Next in Thread]