Re: [patch] update M4 for INET_NTOP and INET_PTON checks.

[Bruno Haible]

Simon Josefsson wrote:
> The recent inet_?to?.m4 change caused build failures in GnuTLS

To avoid future regressions of this kind on these modules, I'm adding a
unit test. Only for IPv4 so far. Feel free to extend it to cover IPv6.

        Tests for module 'inet_pton'.
        * modules/inet_pton-tests: New file.
        * tests/test-inet_pton.c: New file.

        Tests for module 'inet_ntop'.
        * modules/inet_ntop-tests: New file.
        * tests/test-inet_ntop.c: New file.

> Does some autoconf version use the magic string "none needed" and other
> versions "none required"?

No, all autoconf version use the magic string "none required". I checked
them all, since version 2.53. I don't know wherefrom you had the
literal "none needed".

> Perhaps the inet_?to?.m4 code needs to check for both magic strings?

I think it's sufficient to let it check for the correct magic string.
I'm applying this:


2009-11-05  Bruno Haible  <address@hidden>

        Fix link error.
        * m4/inet_ntop.m4 (gl_INET_NTOP): Fix test of AC_SEARCH_LIBS result.
        * m4/inet_pton.m4 (gl_INET_PTON): Likewise.
        Reported by Brad Hards <address@hidden> via Simon Josefsson.

--- m4/inet_ntop.m4.orig        2009-11-05 11:45:31.000000000 +0100
+++ m4/inet_ntop.m4     2009-11-05 11:45:09.000000000 +0100
@@ -1,4 +1,4 @@
-# inet_ntop.m4 serial 10
+# inet_ntop.m4 serial 11
 dnl Copyright (C) 2005, 2006, 2008, 2009 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -18,7 +18,7 @@
     [AC_REPLACE_FUNCS([inet_ntop])])
   LIBS=$gl_save_LIBS
   INET_NTOP_LIB=
-  if test "$ac_cv_search_inet_ntop" != "none needed"; then
+  if test "$ac_cv_search_inet_ntop" != "none required"; then
     INET_NTOP_LIB="$ac_cv_search_inet_ntop"
   fi
   AC_SUBST([INET_NTOP_LIB])
--- m4/inet_pton.m4.orig        2009-11-05 11:45:31.000000000 +0100
+++ m4/inet_pton.m4     2009-11-05 11:45:23.000000000 +0100
@@ -1,4 +1,4 @@
-# inet_pton.m4 serial 8
+# inet_pton.m4 serial 9
 dnl Copyright (C) 2006, 2008, 2009 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -18,7 +18,7 @@
     [AC_REPLACE_FUNCS([inet_pton])])
   LIBS=$gl_save_LIBS
   INET_PTON_LIB=
-  if test "$ac_cv_search_inet_pton" != "none needed"; then
+  if test "$ac_cv_search_inet_pton" != "none required"; then
     INET_PTON_LIB="$ac_cv_search_inet_pton"
   fi
   AC_SUBST([INET_PTON_LIB])