[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: warn-on-use preview, v2
From: |
Eric Blake |
Subject: |
Re: warn-on-use preview, v2 |
Date: |
Mon, 11 Jan 2010 06:55:11 -0700 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666 |
According to Bruno Haible on 1/9/2010 8:53 AM:
> Eric Blake wrote:
>> Here's spin two of the patch.
>
>> [PATCH 1/4] warn-on-use: new module
>> ...
>> + supported by the compiler. If the compiler does not support this
>> + feature, the macro expands to an unused typedef declaration.
>
> It's now an 'extern' declaration, so I would change
> "unused typedef declaration" -> "unused dummy declaration".
I had noticed that as well, and had already changed it in my rebasing.
>
> The rest looks all right.
Thanks for the review. Now applied. I'll start a new thread for the next
patch in the series.
--
Don't work too hard, make some time for fun as well!
Eric Blake address@hidden
signature.asc
Description: OpenPGP digital signature