bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH gnulib 4/4] RFC stat: x86_64 mingw64 #define stat as _stat64.


From: Bruno Haible
Subject: Re: [PATCH gnulib 4/4] RFC stat: x86_64 mingw64 #define stat as _stat64.
Date: Sat, 28 Jan 2012 12:49:31 +0100
User-agent: KMail/4.7.4 (Linux/3.1.0-1.2-desktop; KDE/4.7.4; x86_64; ; )

Marc-André Lureau wrote:
> --- a/lib/tempname.c
> +++ b/lib/tempname.c
> @@ -61,7 +61,7 @@
>  #if _LIBC
>  # define struct_stat64 struct stat64
>  #else
> -# define struct_stat64 struct stat
> +# define struct_stat64 orig_struct_stat
>  # define __gen_tempname gen_tempname
>  # define __getpid getpid
>  # define __gettimeofday gettimeofday

If you have to make such a change to lib/tempname.c, the chances are high
that gnulib users also will have to adapt their programs. Which would be
against the spirit of gnulib: Packages that use gnulib should use the
POSIX or glibc API.

What is the problem in the first place? Which warning or error did you
get? Please also show snippets from the .h files with relevant information.

> #define stat as _stat64

I don't see such a #define in my copy of mingw64. Where do you see it?

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]