Re: [PATCH] maint.mk: get current gnulib revision correctly.

[Gary V. Vaughan]

Hi Bruce,

On Oct 29, 2013, at 4:45 AM, Bruce Korb <address@hidden> wrote:

> On 10/27/13 17:46, Pádraig Brady wrote:
>>>  gnulib_dir ?= $(srcdir)/gnulib
>>> -gnulib-version = $$(cd $(gnulib_dir) && git describe)
>>> +gnulib-version = $$(cd $(gnulib_dir) && git rev-parse --short HEAD)
>>>  bootstrap-tools ?= autoconf,automake,gnulib
> ...
>> This would change the announce message from:
>>   Gnulib v0.0-7848-g4a82904
>> to:
>>   Gnulib 4a82904
> 
> That, or "/path/to/gnulib\nGnulib 4a82904"
> I'd suggest:
>  gnulib-version = $$(cd $(gnulib_dir) >/dev/null && git rev-parse --short 
> HEAD)
> because I've been bitten a number of times.

Good call… that, or an equivalent to the am__cd macro from Automake.

But, since the patch is more contentious than I had anticipated (because
I hadn’t fully understood the problem when I posted it), I’ll wait to
see what solution to the bootstrap shallow clone versus maint.mk requiring
full depth clone issue we settle on before poking at it any more.

> (Hi Gary!)

(wave)

signature.asc
Description: Message signed with OpenPGP using GPGMail