[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] Removed sc_prohibit_strcmp from the syntax-check

From: Kieran Colford
Subject: Re: [PATCH 2/2] Removed sc_prohibit_strcmp from the syntax-check
Date: Wed, 21 May 2014 14:54:48 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

On 14-05-21 02:48 PM, Eric Blake wrote:
> On 05/21/2014 12:00 PM, Kieran Colford wrote:
>> With the removal of STREQ and STRNEQ from gnulib, this syntax test is
>> no longer useful and simply generates a nuisance error message that
>> can't be fixed by gnulib.
> STREQ and STRNEQ have never been provided by a generic .h file in
> gnulib, to my knowledge, so this commit message is misleading.  However,
> several .c files define them rather consistently, as well as
> tests/macros.h (although that header is not installed for use outside of
> tests), and it is easy to copy that definition into your code as well.
>> ---
>>  top/maint.mk |    8 --------
>>  1 file changed, 8 deletions(-)
> I'd rather not remove this rule - at least 2 projects I work on
> (coreutils and libvirt) would be negatively impacted if the rule
> disappears.  Instead, you can customize your cfg.mk to skip this rule
> (by adding it to local-checks-to-skip).
> For that matter, maybe we should add a new gnulib module that can be
> used to provide these macros as part of config.h rather than forcing
> downstream packages to rewrite it themselves.

I guess you're right, but the whole idea of gnulib is so that downstream
packages don't have to rewrite things like these.  I definitely agree
with your suggestion of having a module put them in config.h, I'll see
if I can throw that together then upload a patch.

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]