[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/5] obstacks again

From: Paul Eggert
Subject: Re: [PATCH 0/5] obstacks again
Date: Wed, 29 Oct 2014 00:33:19 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0

Thanks for doing all this. The gnulib patches are good as far as they go, but they need one more change: alignments should also change from int to size_t. The first attached gnulib patch does that, plus it fixes a longstanding integer overflow bug that can occur with large alignments (plus large sizes). While we're in the neighborhood we should be using C11's alignof rather than reinventing that particular wheel; the second attached gnulib patch does that. I've installed your five gnulib patches plus the two attached patches into gnulib.

Two things for the glibc patch. First, the updated gnulib patches need to be merged into the glibc patch. Second, the manual needs to be updated to match the revised API induced by all these patches.

And thanks again.

Attachment: 0001-obstack-use-size_t-alignments-and-check-for-overflow.patch
Description: Text document

Attachment: 0002-obstack-prefer-alignof-to-calculating-alignments-by-.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]