[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 02/14] Fix character encoding aliases for OS/2

From: KO Myung-Hun
Subject: Re: [PATCH 02/14] Fix character encoding aliases for OS/2
Date: Fri, 26 Dec 2014 12:15:30 +0900
User-agent: Mozilla/5.0 (OS/2; Warp 4.5; rv:10.0.6esrpre) Gecko/20120715 Firefox/10.0.6esrpre SeaMonkey/2.7.2

Daiki Ueno wrote:
> Thanks for the update.  I'm attaching a slightly modified version of the
> patch, with typo and style fixes (e.g. adding two spaces after a period,
> according to GCS, etc).

Thanks. ^^ And fixed typo, cp1361 to cp1381.

> KO Myung-Hun <address@hidden> writes:
>> I used CODEPAGE and COUNTRY parts of OS/2 command references.
> Could you provide the title and the corresponding section number of the
> manual?  For example, for VMS, we have the following comment:
>       /* The list of encodings is taken from the OpenVMS 7.3-1 documentation
>          "Compaq C Run-Time Library Reference Manual for OpenVMS systems"
>          section 10.7 "Handling Different Character Sets".  */

I added a document file name and entries.

>> And the differences of others is because cp915, cp921 and cp1381 are not
>> supported by libiconv. In these cases, I picked up code pages from
>> config.charset.
> I see.
>> Finally, I changed a code page for bg_BG from cp1251 to cp855 which is
>> etc code page.
> Is this a desired change?  It seems those codepages are largely
> incompatible.  I changed this to ISO-8859-5.

But cp855 is used on OS/2. So I decided it. But ISO-8859-5 is equivalent
to cp915, no problem.

> By the way, it's tempting to call DosQueryCp if a charset is omitted
> from the locale name, to avoid maintaining the default mapping
> ourselves.  I'd rather not do that for now, but is it feasible?

This was my first idea. But Bruno rejected. See


KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr

Attachment: 0001-localcharset-embed-charset-aliases-for-OS-2.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]