[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [platform-testers] new snapshot available: sed-4.4.104-290c

From: Eric Blake
Subject: Re: [platform-testers] new snapshot available: sed-4.4.104-290c
Date: Sat, 24 Mar 2018 05:53:34 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 03/23/2018 06:53 PM, Jim Meyering wrote:
On Fri, Mar 23, 2018 at 4:23 PM, Assaf Gordon <address@hidden> wrote:
(adding bug-gnulib@ because of 'test-localename' failure)

Additionally, on Alpine linux which uses busybox's diff(1),
the following fails:
   FAIL: test-version-etc.sh

   diff: unrecognized option: c
   FAIL test-version-etc.sh (exit status: 1)

Wow. Thank you for all that prompt testing.

@@ -36,7 +36,7 @@ EOT
       /^Packaged by/d
       2,3 s/Copyright (C) [0-9]\{4,4\}/COPYRIGHT/' |
  tr -d '\015' |
- diff -c $TMP - || ERR=1
+ diff $TMP - || ERR=1

Is 'diff -u' portable to busybox? ed script diffs are a pain to read in comparison to context or unified diffs, so I think this change is a reduction in quality if something better is available.

POSIX requires diff to support both -u and -c; you may want to also report the missing support for -c to the busybox maintainers.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]