[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] hmac-*: refactor to remove repetitive code

From: Pádraig Brady
Subject: Re: [PATCH 2/2] hmac-*: refactor to remove repetitive code
Date: Sun, 30 Sep 2018 15:53:38 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

On 30/09/18 11:22, Bruno Haible wrote:
> Hi Pádraig,
> With this patch, I see a small regression:
>>  #include <config.h>
>> -
>> -#include "hmac.h"

> There is no verification any more that hmac.h is self-contained.
> As mentioned just yesterday, the best practice is to #include the
> specification header right after <config.h>.

Oops. Fixed.

I also reduced some more repetition
within the hmac function itself.

I'll squash in the attached, and push later.

thanks for the review!

Attachment: hmac-adjustments.diff
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]