[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/8] safe-alloc: improve doc

From: Eric Blake
Subject: Re: [PATCH 1/8] safe-alloc: improve doc
Date: Thu, 22 Apr 2021 13:20:45 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 4/18/21 11:01 PM, Paul Eggert wrote:
> * doc/safe-alloc.texi: Clarify that reallocating an array appends
> uninitialized storage.  Say ‘sizeof *p’ rather than ‘sizeof(*p)’
> which would need a space before the paren to follow GNU style.

Something in you recent malloc work (I'm not yet sure if it was this
particular series) is breaking compilation on Fedora Rawhide:

  CC       regex.o
In file included from regexec.c:1368,
                 from regex.c:74:
./malloc/dynarray-skeleton.c:195:24: error: expected declaration
specifiers or '...' before '(' token
  195 | __attribute_nonnull__ ((1))
      |                        ^

Looks like the definition of macro  __attribute_nonnull__ from cdefs.h
is no longer implicitly picked up by the system headers used in that file.

I'm still poking around to see if I can fix it, but you're welcome to
beat me to it..

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]