[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/8] safe-alloc: improve doc
From: |
Eric Blake |
Subject: |
Re: [PATCH 1/8] safe-alloc: improve doc |
Date: |
Thu, 22 Apr 2021 15:27:52 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 4/22/21 1:20 PM, Eric Blake wrote:
> On 4/18/21 11:01 PM, Paul Eggert wrote:
>> * doc/safe-alloc.texi: Clarify that reallocating an array appends
>> uninitialized storage. Say ‘sizeof *p’ rather than ‘sizeof(*p)’
>> which would need a space before the paren to follow GNU style.
>
> Something in you recent malloc work (I'm not yet sure if it was this
> particular series) is breaking compilation on Fedora Rawhide:
>
> CC regex.o
> In file included from regexec.c:1368,
> from regex.c:74:
> ./malloc/dynarray-skeleton.c:195:24: error: expected declaration
> specifiers or '...' before '(' token
> 195 | __attribute_nonnull__ ((1))
> | ^
>
For closure on this thread, my git bisect finally ended at fc6d7d850
"libc-config: port to DragonFlyBSD 5.9" as the point the problem was
introduced; but since the fix is already in, this observation is now
just for archival purposes
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [PATCH 4/8] xalloc: new function xreallocarray, (continued)
- [PATCH 4/8] xalloc: new function xreallocarray, Paul Eggert, 2021/04/19
- [PATCH 6/8] safe-alloc: simplify via reallocarray, Paul Eggert, 2021/04/19
- [PATCH 7/8] calloc-gnu: now LGPLv2+, Paul Eggert, 2021/04/19
- [PATCH 8/8] safe-alloc: fix pointer implementation, Paul Eggert, 2021/04/19
- [PATCH 5/8] xalloc-oversized: fix SIZE_MAX optimization bug, Paul Eggert, 2021/04/19
- Re: [PATCH 1/8] safe-alloc: improve doc, Eric Blake, 2021/04/22