[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 05/10] Make gnulib's regcomp not abort()

From: Paul Eggert
Subject: Re: [PATCH v2 05/10] Make gnulib's regcomp not abort()
Date: Tue, 7 Dec 2021 15:54:12 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0

On 12/7/21 10:51, Robbie Harwood wrote:
I don't believe we have an implementation of abort() that can
be called.  (We have grub_abort() instead.)  If that's the correct
reason, then DEBUG_ASSERT would work and I can make that change.

Looking into the code a bit more, it looks like a DEBUG_ASSERT would not be appropriate at least for the first 'abort ()' since the code is trying to make glibc regerror more user- and debugger-friendly, and using DEBUG_ASSERT would make it less friendly.

Can you compile regexec.c with -Dabort=gnu_abort instead?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]