[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: libtextstyle-optional fails ./gnulib-tool --test

From: Bruno Haible
Subject: Re: libtextstyle-optional fails ./gnulib-tool --test
Date: Sat, 25 Dec 2021 14:38:35 +0100

Paul Eggert wrote:
> The command "./gnulib-tool --test libtextstyle-optional" fails with the 
> last few output lines as follows. I tried going back into the past but 
> didn't find an old Gnulib version where the command worked (though the 
> failure symptoms differed), so I don't think this is purely due to 
> recent Gnulib changes.
> gcc -DHAVE_CONFIG_H -I. -I../../gltests -DGNULIB_STRICT_CHECKING=1 -I. 
> -I../../gltests -I.. -I../../gltests/.. -I../gllib 
> -I../../gltests/../gllib -DSRCDIR=\"../../gltests/\"   -Wno-error -g -O2 
> -MT test_libtextstyle-test-libtextstyle.o -MD -MP -MF 
> .deps/test_libtextstyle-test-libtextstyle.Tpo -c -o 
> test_libtextstyle-test-libtextstyle.o `test -f 'test-libtextstyle.c' || 
> echo '../../gltests/'`test-libtextstyle.c
> ../../gltests/test-libtextstyle.c:20:10: fatal error: textstyle.h: No 
> such file or directory
>     20 | #include <textstyle.h>
>        |          ^~~~~~~~~~~~~
> compilation terminated.

Thanks for the report. Fixed through the attached two patches. Up until
yesterday, only the second one would have been necessary. Now, also the
'gen-header' module needs to be repeated in tests/Makefile.am; this is
handled by the first patch.

There is no problem when the option --single-configure is used.

So, the situation is that there are two configure.ac files: one at the
top level and one in gltests/.

$ grep TEXTSTYLE config.status 

$ grep TEXTSTYLE gltests/config.status 

So, the module 'libtextstyle-optional' is special: The AC_SUBSTed
values, such as TEXTSTYLE_H, are different in the two configurations.
This is because the gl_LIBTEXTSTYLE_OPTIONAL invocation comes only
in the tests. As a consequence, omitting the module in the tests/configure.ac
is not OK.

2021-12-25  Bruno Haible  <bruno@clisp.org>

        gnulib-tool: Fix handling of module libtextstyle-optional.
        Reported by Paul Eggert in
        * gnulib-tool (func_repeat_module_in_tests): New function.
        (func_emit_tests_Makefile_am, func_create_testdir): Use it for the file
        list and when creating tests/Makefile.am.

2021-12-25  Bruno Haible  <bruno@clisp.org>

        gnulib-tool: Respect applicability 'all' without --single-configure.
        * gnulib-tool (func_verify_tests_module): Treat modules with
        applicability 'all' like 'tests' modules, not like 'main' modules.

Attachment: 0001-gnulib-tool-Respect-applicability-all-without-single.patch
Description: Text Data

Attachment: 0002-gnulib-tool-Fix-handling-of-module-libtextstyle-opti.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]