Re: NSTextField.m patch

[Nicola Pero]

> Hi Nicola,
> 
>  NP> > Here is a patch that makes selectText working (i.e. highlight text 
> after
>  NP> > Return key pressed).
>  NP> 
>  NP> what is exactly your problem ?
>  NP> 
>  NP> Can you tell me how to reproduce it ?
> 
>   Create NSTextField. Enter into it some text. Press Return key. Entire
>   contents of the text field should be selected(highlighted). But it doesn't.
>   Moreover, if i try to select text by NSTextFiled's selectText:
>   method (in controlTextDidEndEditing: delegate's method), text flashes 
>   from selected(highlighted) to unselected and stays unselected.

Ok - thanks - I didn't know about this possibility - but it seems you are
right - the NeXTSTEP 3.3 user interface guidelines and documentation
clearly states -

"For the user's convenience, if the action associated with Return is
repeatable, Return may select all the text in the same field so the user
can easily replace it."

I don't think that implies that Return should alwasy select all the text,
but it definitely implies that it should be easy for you to change the
behaviour so that it does when it's for the user convenience.

I think calling selectText: in controlTextDidEndEditing: should do it ...
but I can see why it didn't - I think the bug was in NSTextField.m, which
was posting the 'NSControlTextDidEndEditing' notification too early -
before actually ending editing!

I fixed this on CVS - if you try again from CVS, hopefully now using
selectText: inside controlTextDidEndEditing: should now work :-) [I didn't
try it, so please let me know if you still have problems]

thanks