Re: Selection patches

[Serg Stoyan]

Hello, Nicola Pero.

 NP> just to let you know that your patch has not been forgotten ... we are
 NP> currently approaching gnustep-gui 0.8.0 freeze, so we're now trying to
 NP> apply only small and safe patches to try not break the gui just before the
 NP> release ... I'll look at your patch (which changes drawing the selection,
 NP> which is quite delicate) after the 0.8.0 release.

  It's ok, Nicola. Besides, after some playing around selection, i'm
  working on more intelligent drawing(most code goes into 
  GSSimpleLayoutManager.m). Patch i've sent may be considered evil. I'll
  send a new one. The main problem is after moving from
  NSHighlightRect() to [NSTextStorage addAttribute:] selection style,
  selection drawing works only from the beginning of line. If I for
  example start dragging mouse from the second character of the line,
  selection not drawing. However, selection sets(Copy, Paste, Cut
  works).

 
 NP> Thanks for contributing! - sorry for keeping your patch on hold.
  
  Thanks for this mail.

 NP> > The following patches changes a way of selected text highlighting 
(NSTextField,
 NP> > NSTexView, etc.). Now selected text highlights with 
 NP> > [NSColor selectedTextBackground] instead of NSHighlightRect().
 NP> > 
 NP> > However it's not finished. Here the things that works:
 NP> >   - double click selects all text;
 NP> >   - selecting text by mouse and keyboard(Shift-RightArrow) only from the 
 NP> >     beginning of the text line (text field);
 NP> >   - clicking on the text object(e.g NSTextView) unhighlights text;
 NP> >   - pressing motion keys unhighlits text;
 NP> >  
 NP> > Here the things have to do:
 NP> >   - selecting text inside line;
 NP> >   - selecting text from the end of line (NSSelectionAffinityUpstream?);
 NP> > 
 NP> > Does anybody has suggestions about TODOs? I don't understand why
 NP> > selection inside text(not from beginning) doesn't highlights text?
 NP> 

-- 
Serg Stoyan