[PATCH] ugly transient menus bug

[Michael Hanni]

Hi,

With NSMenuWindowTitleView now residing in NSMenuView there are new added
complications for transient menus. The code before moved the _titleView to the
relevant window -- transient or normal -- in the display and close methods in
NSMenu. However, with the new code the _titleView has a tendency to get stuck
in the normal window, which can cause some ugly transient windows.

Procedure to view this bug:

1.) Fire up GSTest.app
2.) Tear off both the Windows and Tests submenus.
3.) Open in this order: Composite Test, NSBox test, and NSSecureTextField test.
    (this works for me, there are any number of ways to trip this up.)
4.) Open the Windows menu and look at its transient window (it should look
    flawless.)
5.) Select NSSecureTextField Test from the windows menu and close the test.
6.) Open the Windows menu again. The transient window will have either multiple

    title bars or the menuview will be off-kilter horribly.

The attached patch is really the mother of all hacks that tries to maintain the
titleView in the correct window for display purposes. I'm not really sure if my
reference counting is correct in this...

Well, sorry for this evil hack... :-)

2003-03-26  Michael Hanni   <michael@deviant-behavior.com>

        * Source/NSMenuView.m (update): hijack the update method to make sure
        our title view is in the correct window.

Michael

nsmenuview-moah.diff
Description: nsmenuview-moah.diff