bug-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Patches for GDL2


From: Stéphane Corthésy
Subject: Patches for GDL2
Date: Fri, 4 Apr 2003 21:56:39 +0200

Hi,

here are some other patches for GDL2 (I still have lots in stock!).
In MacOS X 10.2, there are some classes (public or private) which deserve to be used IMHO: NSClassDescription, NSFault (private, undocumented) and NSFaultHandler (private, undocumented). Seems these are (quite) straight ports from EOF, down to Foundation. Until we have tests, I can't assure you that they all work fine, but till now, in my examples, they seem to work reliably well. Moreover, I can't make GDL2's EOFault work on OSX, because I miss the implementation of -[NSInvocation returnFrame:] and -[NSInvocation initWithArgframe:selector:] for faults.

I've modified EOClassDescription, EOFault and EOFaultHandler classes to subclass these classes, and to implement only missing methods, or methods that need to be overloaded. I've used HAVE_NSCLASSDESCRIPTION, HAVE_NSFAULT and HAVE_NSFAULTHANDLER macros. Code is a bit messy, due to all these #ifdef, but it works. Note that in case HAVE_NSFAULT is #defined, the config.h file needs to also #define EOFault NSFault

I guess you could also use base's NSClassDescription implementation as superclass of EOClassDescription, if it works fine; this would avoid duplicating code and functionalities.

Stéphane


Changelog
EOControl/EOClassDescription.h: use GDL2CONTROL_EXPORT instead of extern; added use of HAVE_NSCLASSDESCRIPTION all around to reuse NSClassDescription EOControl/EOClassDescription.m: added use of HAVE_NSCLASSDESCRIPTION all around to reuse NSClassDescription; make use of global vars instead of their values; added some casts EOControl/EOFault.h: added use of HAVE_NSFAULT to reuse implementation of NSFault EOControl/EOFault.m: added use of HAVE_NSFAULT to reuse implementation of NSFault and NSFaultHandler EOControl/EOFaultHandler.m: added use of HAVE_NSFAULT to reuse implementation of NSFaultHandler

Attachment: EOControl-patch.txt.gz
Description: GNU Zip compressed data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]