Re: bug in popup button

[Serg Stoyan]

Hello Alexander,

> Serg Stoyan wrote:
> >   On OPENSTEP, InteraceBuilder doesn't allow to remove last item from
> >   NSPopUpButton. I think we should do it as well, so removeAllItems
> >   should leave item with empty title or item at index 0. I'll check it
> >   with OPENSTEP.
> 
> This is wrong. The documentation simply states the -removeAllItems
> removes all items, and testing on OPENSTEP confirms that it does this
> (besides, it makes no sense to leave items in the item list just to
> prevent the drawing from crashing).

  Agree. Already fixed.

> Leaving an item in the internal item array for drawing purposes can be
> one way of handling the issue, but you need to be _extremely_ careful
> that the dummy item is _never_ seen outside NSPopUpButtonCell, and I
> think trying to handle it that way will be a lot trickier and more
> fragile then dealing with an empty array when drawing.

  Now it's just draws temporary menu item cell.

> I'm adding some tests for this to the -gui test suite, so regardless of
> how it is implemented, they need to pass.

  Ok.

-- 
Serg Stoyan