[PATCH] Re: bug in popup button

[Michael Hanni]

Hi,

--- Jeff Teunissen <deek@d2dc.net> wrote:
> On OPENSTEP:
> 
> An empty (zero items) popup button beeps when you click it, and does
> nothing else (no menu appears, no action is sent).
> 
> Both itemsArray and numberOfItems can return zero.

Ok, I've attached a patchset, against the latest CVS code, which implements
these behaviors without fidgeting about with "hidden" menuitems. It even beeps
when you click on, or activate with a key click, a popupbutton which has zero
items.

It compiles here, (tm), and seems to work well with the popuptest that Benhur
sent a few days ago. I am very green when it comes to reference counting so if
someone could check that I'd appreciate it. I put comments in the code so
hopefully y'all can follow my thinking.

There are some issues with the menu item cell size calculations that are
brought to light with the PopUpTest.app, but that is a seperate topic.

Cheers,

Michael

NSPopUpButton.patch
Description: NSPopUpButton.patch

NSPopUpButtonCell.patch
Description: NSPopUpButtonCell.patch