[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch for gui/Tools/example.m
From: |
Richard Frith-Macdonald |
Subject: |
Re: Patch for gui/Tools/example.m |
Date: |
Mon, 12 May 2003 20:39:59 +0100 |
On Monday, May 12, 2003, at 07:44 pm, Chris B. Vetter wrote:
On Mon, 12 May 2003 11:44:04 -0700
"Chris B. Vetter" <chrisv@web4inc.com> wrote:
Hi,
attached is a unified DIFF for gui/Tools/example.m that fixes the
signal() issues that occasionally take down my X11 sessions.
The patch basically implements the same things as the patch I sent
for back/Tools/gpbs.m a while ago.
However ... the original code is 'right' and the patch is 'wrong' ...
the original code calls abort() ... which is the correct way to
terminate a
program so that you can get a core-dump and debug it.
For a daemon like gpbs which should really never crash, it's important
that we should be able to debug it if it does crash, and it's good
practice
in general to call abort() if you can't manage to recover from an error.
Also ... barring a kernel bug, the signal status of the process will
have
no effect on any other process ... so if your X11 session is dieing,
doesn't it make more sense to try to figure out what the bug is ...
rather than trying to change other software to hide the problem?