Re: [PATCH] Proposal to fix NSCell issue

[Quentin Mathé]

Le 1 avr. 04, à 01:40, Fred Kiefer a écrit :

> Sorry, as I wrote, I was not sure. After your mail I checked and it is 
> there on NSButton and NSButtonCell at least in my OpenStep 
> specification (October 19, 1994, not sure if there are different 
> versions). As this issue is becoming a bit strange now, would you mind 
> to state explicitly what you and Alexander are aiming at?
> My position is rather clear: Trying to improve our actual 
> implementation, while keeping an interface that is compliant to 
> OpenStep as well as to Cocoa. Which is fairly easy in this specific 
> case, as the two are not conflicting. I hope, that you are with me 
> here and we just keep this method and apply the rest of the patch.
>
> Fred
> (a bit confused)

Don't be confused :-). The problem is the following, Apple has added 
-performClick: to NSCell but this is impossible to implement without 
large modifications on NSMatrix for example (see my first set of 
patches) and moreover it doesn't fit very well with the NSCell 
philosophy : when you ask something to a cell you should pass a frame 
and a view for the display with the method arguments.
Then Alex and me have thought it would better to deprecate NSCell 
-performClick: method in favor of a more NSCellish method like 
performClickWithFrame:inView: which follows the NSCell philosophy like 
drawInteriorWithFrame:inView:.

Now you are saying -performClick: method for NSButtonCell is part of 
the OpenStep specification. Then I agree now to not remove this method 
in NSButtonCell and NSCell also to stay compatible with Apple and 
OpenStep spec. I think we should just deprecate such method for the 
moment, but I still think also that -performClick in NSCell (like 
Apple) or in NSButtonCell (like OpenStep spec.) is a design error.

You must know also that with my proposed set of patches NSCell 
NSButtonCell will still be unusable inside an NSMatrix with the method 
-performClick. Here I reassert this is the reason to deprecate it in 
favor of performClickWithFrame:inView:

I hope I have been clearer than the light ;-).

Quentin.

--
Quentin Mathé
qmathe@club-internet.fr