Re: [PATCH] Proposal to fix NSCell issue

[Fred Kiefer]

Quentin Mathé wrote:
> Le 23 mars 04, à 01:07, Quentin Mathé a écrit :
>
> > Well, here is two patches which add -performClickWithFrame:inView: to 
> > NSCell and mark performClick: as deprecated.
> > If everybody is ok, I can commit this NSCell modification.
>
>
> Here are a more complete set of patches to fix the related issues :

I like the code in NSCell and also the cleanup of the unneeded 
defintions for NSButton, what worries me is the sending of the action in 
NSButtonCell. This already gets done in the super class, so why 
doublicate it here?
Also I see no reason for the change on NSWindow, performClick: will 
still work, so why change it? For NSPopupButtonCell the documentation 
states that the default action should be the the opening of the popup, 
so perhaps the whole code here is unneeded we just should set up the 
action and target correctly for the cell. And for NSCell the 
documentation has some hint that the sender will be used if no control 
view is already set.

Fred