[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug #25384] validateToolbarItem: not being called very often
From: |
Richard Frith-Macdonald |
Subject: |
[bug #25384] validateToolbarItem: not being called very often |
Date: |
Sat, 31 Jan 2009 06:30:27 +0000 |
User-agent: |
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_6; en-us) AppleWebKit/525.27.1 (KHTML, like Gecko) Version/3.2.1 Safari/525.27.1 |
Follow-up Comment #4, bug #25384 (project gnustep):
I'm not familiar with the toolbar code, but out of interest I had a quick
look.
The comments at the start of the file make it clear that the validation code
here is designed to only update infrequently and only update if the mouse is
in the window. indeed there's quite a bit of complex code there which seems
(to my naive eye) intended primarily to ensure that things are NOT validated
once per window update.
Looking at the Apple documentation, I haven't seen anything to say that
validation should be done either infrequently or only when the mouse is in the
window, and my natural intuition is to say that validation should be done as
long as the toolbar is visible, whether the mouse is in the window or not, and
should be done for every window update (though not recursively).
However, I'll leave this one to Greg as I guess he knows the rationale behind
the current setup.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?25384>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/