Re: patch suggestion for GSMime.m

[Fred Kiefer]

On 06.09.2013 20:42, Pirmin Braun wrote:
> this was a bug for serveral years. Upload of Files with Umlaute in the 
> filename didn't work.
> With this modification it works.

Hi Pirmin,

could you please give an example of a text wrongly decoded by the old
code and correctly handled by yours? By looking at the patch I don't see
how this would result in a better decoding.
There definitely is one problem with your code. After decoding with
NSISOLatin1StringEncoding failed this is no use to try
NSASCIIStringEncoding which is a strict subset.

This means the main change of your code is that you always use
NSISOLatin1StringEncoding first, where the old code only did this for
flags.isHttp == 1. The second difference is that you don't try the
_defaultEncoding. Which of these should make the difference?

Fred