Re: patch suggestion for GSMime.m

[Pirmin Braun]

Am Sat, 07 Sep 2013 18:13:04 +0200
schrieb Fred Kiefer <fredkiefer@gmx.de> :

> On 06.09.2013 20:42, Pirmin Braun wrote:
> > this was a bug for serveral years. Upload of Files with Umlaute in the 
> > filename didn't work.
> > With this modification it works.
> 
> Hi Pirmin,
> 
> could you please give an example of a text wrongly decoded by the old
> code and correctly handled by yours? By looking at the patch I don't see
> how this would result in a better decoding.
> There definitely is one problem with your code. After decoding with
> NSISOLatin1StringEncoding failed this is no use to try
> NSASCIIStringEncoding which is a strict subset.

http://pirmin.de/GSWeb/Aprica3000230.woa/?pw=root&loginname=Administrator
type "upload" in the "gehe zu.." Field and click "upload".
take a "aä.pdf" file and try to upload  with Chrome or Firefox in a Web App 
using GSWeb, i.e. IntarS:
it won't work.
rename the file to "a.pdf" and try again, it will work.
This is in a very old Rev. of GNUstep.

In the Head Revision the behaviour was still the same until I changed the 
GSMime.m according to the patch.
The order of trying the encodings might be wrong but at least now every 
encoding is tried.

> 
> This means the main change of your code is that you always use
> NSISOLatin1StringEncoding first, where the old code only did this for
> flags.isHttp == 1. The second difference is that you don't try the
> _defaultEncoding. Which of these should make the difference?
> 
> Fred


-- 
Pirmin Braun - IntarS Unternehmenssoftware GmbH - Am Hofbräuhaus 1 - 96450 
Coburg
+49 2642 40526292 +49 174 9747584 - skype:pirminb www.intars.de  pb@intars.de
Geschäftsführer: Pirmin Braun, Ralf Engelhardt Registergericht: Amtsgericht 
Coburg HRB3136