[bug #59443] PATCH] src/preproc/tbl/table.cpp: add "tbl:" to diagnostic messages

[Bjarni Ingi Gislason]

URL:
  <https://savannah.gnu.org/bugs/?59443>

                 Summary: PATCH] src/preproc/tbl/table.cpp: add "tbl:" to
diagnostic messages
                 Project: GNU troff
            Submitted by: bjarniig
            Submitted on: Tue 10 Nov 2020 05:35:23 PM UTC
                Category: Preprocessor tbl
                Severity: 3 - Normal
              Item Group: New feature
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None

    _______________________________________________________

Details:

  Add "tbl:" to diagnostic messages.

  The GNU standard recommends the following:

"   Error messages from other noninteractive programs should look like
this:

     PROGRAM:SOURCEFILE:LINENO: MESSAGE

when there is an appropriate source file, or like this:

     PROGRAM: MESSAGE

when there is no relevant source file.
"

  This mark should reduce the risk that users blame a command,
that itself uses "tbl" internally, like "man",
for the diagnostic,
and report it to the maintainers of that software.

  This is an addition to comply to the bug report #52463.

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
 src/preproc/tbl/table.cpp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/preproc/tbl/table.cpp b/src/preproc/tbl/table.cpp
index 5f8ac27a..25e3f198 100644
--- a/src/preproc/tbl/table.cpp
+++ b/src/preproc/tbl/table.cpp
@@ -1860,7 +1860,7 @@ void table::init_output()
           /* Since we turn off traps, it won't get into an infinite
              loop when we try and print it; it will just go off the
              bottom of the page. */
-          ".  tmc \\n[.F]: around line \\n[.c]: warning:\n"
+          ".  tmc tbl:\\n[.F]: around line \\n[.c]: warning:\n"
           ".  tm1 \" table row will not fit on page \\n%\n"
           ".\\}\n"
           ".nf\n"
@@ -1891,7 +1891,7 @@ void table::init_output()
           ".nr " SAVED_DN_REG " \\n[dn]\n"
           ".ne \\n[dn]u+\\n[.V]u\n"
           ".ie \\n[.t]<=\\n[" SAVED_DN_REG "] \\{\\\n"
-          ".  tmc \\n[.F]: around line \\n[.c]: error:\n"
+          ".  tmc tbl:\\n[.F]: around line \\n[.c]: error:\n"
           ".  tmc \" table will not fit on page \\n%;\n"
           ".  tm1 \" use .TS H/.TH with a supporting macro package\n"
           ".\\}\n"
@@ -2153,7 +2153,7 @@ void table::compute_expand_width()
           "delim off\n"
           ".EN\n"
           "..\n");
-    prints(".tmc \\n[.F]: around line \\n[.c]: warning:\n"
+    prints(".tmc tbl:\\n[.F]: around line \\n[.c]: warning:\n"
           ".tm1 \" table wider than line width\n");
     prints(".ig\n"
           ".EQ\n"
@@ -2205,7 +2205,7 @@ void table::compute_separation_factor()
           "delim off\n"
           ".EN\n"
           "..\n");
-    prints(".tmc \\n[.F]: around line \\n[.c]: warning:\n"
+    prints(".tmc tbl:\\n[.F]: around line \\n[.c]: warning:\n"
           ".tm1 \" column separation set to zero\n"
           ".nr " SEPARATION_FACTOR_REG " 0\n");
   }
@@ -2213,7 +2213,7 @@ void table::compute_separation_factor()
         ".el .if \\n[" SEPARATION_FACTOR_REG "]<1n \\{\\\n");
   entry_list->set_location();
   if (!(flags & NOWARN)) {
-    prints(".tmc \\n[.F]: around line \\n[.c]: warning:\n"
+    prints(".tmc tbl:\\n[.F]: around line \\n[.c]: warning:\n"
           ".tm1 \" table squeezed horizontally to fit line length\n");
     prints(".ig\n"
           ".EQ\n"
-- 
2.28.0






    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?59443>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/