[bug #61854] [tbl] tables lacking 'x' column modifier don't get table width warnings

[G. Branden Robinson]

Update of bug #61854 (project groff):

                  Status:             In Progress => Fixed                  
             Open/Closed:                    Open => Closed                 
         Planned Release:                    None => 1.23.0                 

    _______________________________________________________

Follow-up Comment #6:


commit 77e6fb6bce3edcca62416c956f8d13fff33b5a78
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Thu Jan 20 16:20:11 2022 +1100

    [tbl]: Fix Savannah #61854.

    * src/preproc/tbl/table.cpp (compute_expand_width): To properly warn if
      a table is too wide to fit between the indentation and the right
      margin, we need to compute its column widths including those eligible
      for expansion via the 'x' column modifier; we cannot use the same
      expression that we do to determine how the amount of space we have to
      distribute among the expanded columns.  Iterate through columns again
      (the function was already doing so twice), once to potentially produce
      the warning, and then as before to distribute any available width.  In
      other words, warnings were only being emitted for too-wide tables
      where one or more columns used the 'x' modifier.

    Fixes <https://savannah.gnu.org/bugs/?61854>.



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?61854>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/