[bug #60598] tbl reports incorrect line numbers in diagnostics

[G. Branden Robinson]

Update of bug #60598 (project groff):

                  Status:             In Progress => Fixed                  
             Open/Closed:                    Open => Closed                 
         Planned Release:                    None => 1.23.0                 

    _______________________________________________________

Follow-up Comment #4:


commit e4162062cd69ffbe18058f53379f58a53d17d17d
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Fri Jan 21 00:02:18 2022 +1100

    [tbl]: Fix incorrect line numbers in diagnostics.

    Line numbers for multiple format-time diagnostics emitted by
    tbl(1)-generated groff input were off by +5 lines.

    * src/preproc/tbl/table.cpp: Fix it.
      (NOP_NAME): Add new preprocessor symbol to construct name of "nop"
      macro to be used as end macros for `ig` requests inside macro
      definitions.

      (table::init_output, table::compute_expand_list,
      table::compute_separation_factor):
        - Move `entry_list->set_location()` calls to more auspicious
          locations.
        - Replace "around line X" language in diagnostic messages with a
          more idiomatic, and less embarrassing, simple report of an
          integer.

      (table::init_output):
        - Add `entry_list->set_location()` call right before emitting
          diagnostic about a table row not fitting on a page.
        - Turn off eqn(1) delimiters when emitting diagnostic about a boxed
          table not fitting on a page (necessitating `.TS H` support), using
          new NOP_NAME-based end macro to achieve this inside a macro
          definition.

      (table::compute_expand_list): Suppress issue of too-wide table
      diagnostic when the `EXPAND` table flag is set (corresponding to the
      `expand` region option), because other code already emits diagnostics
      in this case.

    Fixes <https://savannah.gnu.org/bugs/?60598>.  Problem appears
    to date back to commit 3bc4a53a45, 2013-01-07.



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?60598>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/