Re: Reiser4 and GRUB...

[Yury Umanets]

Yoshinori K. Okuji wrote:

> At Fri, 23 May 2003 13:16:31 +0400,
> Yury Umanets wrote:
>  
>
> > Probably I'd like modify GRUB to support reiser4, but how should I do 
> > it? Currently the main problem is size. We can do not use library  
> > approach, but this way has few weeknesses. And main of them is need to 
> > modidfy reiser4 code in more then one places (libreiser4, GRUB)
> >    
>
> I mean that you modify the file "stage2/fsys_resiserfs.c".

> Of course,
> I don't know much about Reiser4, so I can't see if this is better than
> using your library. I'm just wondering how difficult this is (compared
> to your approach).
There is nothing to modify. Whole fsys_reiser4.c is about 5K of source 
code. The rest is inside our library. Now I'm working on making overhead 
lesser. I mean, that libreiser4 is built on using plugins and for 
instance, each plugin takes 210 bytes for method declarations and other 
things. There are also yet another things, which do our stage1_5 
bigger.  For instance, memory allocator.

I'm sure, that I will cut it out soon.

> Generally speaking, I understand it is a Good Thing to maintain a
> single source tree rather than several independent source
> trees.

> However, we have been developing/maintaining code for
> supporting many filesystems for some years, and we haven't had many
> troubles with it, actually. Therefore, I guess the cost of maintaining
> fsys_reiserfs.c independently wouldn't be significantly different.
In general you are right. But consider about adding new plugins used for 
root reiser4 filesystem. These plugins should be handled too. Also these 
plugins may not be standard ones. I mean, that anyone is able to add 
something in kernel code first and then in library. And in the case of 
using current approach we will have supported GRUB out of the box. At 
least using it with stage2 only.

> Okuji
>
>
>  
Thanks for answer. I thought before, that address@hidden list is not 
friendly one.  But I was wrong :)

--
Yury Umanets
"We're flying high, we're watching the world passes by..."