bug-gsl
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bug-gsl] GSL and minGW, gcc


From: Sisyphus
Subject: Re: [Bug-gsl] GSL and minGW, gcc
Date: Wed, 15 Apr 2009 20:35:49 +1000


----- Original Message ----- From: "Dr. Michael Letzgus" <address@hidden>
To: <address@hidden>
Sent: Wednesday, April 15, 2009 6:09 PM
Subject: Re: [Bug-gsl] GSL and minGW, gcc


"make check" reports "All tests passed" (version 1.12).

That's a bit strange - usually, on Windows, some of the Monte tests fail.

In a thread in early February this hear, Guido de Rosa proprosed the following patch (which works fine for me):

######################################
diff -ruN gsl-1.12.orig/monte/vegas.c gsl-1.12/monte/vegas.c
--- gsl-1.12.orig/monte/vegas.c 2008-11-29 17:42:43.000000000 +0100
+++ gsl-1.12/monte/vegas.c 2009-02-02 02:43:23.289790431 +0100
@@ -179,7 +179,8 @@
        }

      {
-        double tot_boxes = pow ((double) boxes, (double) dim);
+        unsigned int tot_boxes =
+          (unsigned int) gsl_pow_int((double) boxes, dim);
        state->calls_per_box = GSL_MAX (calls / tot_boxes, 2);
        calls = state->calls_per_box * tot_boxes;
      }

######################################

There were also some other solutions discussed in the same thread. But, afaik, none of those solutions are built into the 1.12 source.

I think the above patch is deemed to be the correct fix, though I'm not sure about that.

Cheers,
Rob




reply via email to

[Prev in Thread] Current Thread [Next in Thread]