[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#40528: 'guix lint' does not check whether propagated-inputs should b
From: |
Efraim Flashner |
Subject: |
bug#40528: 'guix lint' does not check whether propagated-inputs should be native |
Date: |
Fri, 10 Apr 2020 00:50:10 +0300 |
On Thu, Apr 09, 2020 at 11:42:18PM +0200, Marius Bakke wrote:
> Efraim Flashner <address@hidden> writes:
>
> > On Thu, Apr 09, 2020 at 11:24:25PM +0200, Marius Bakke wrote:
> >> 'guix lint -c inputs-should-be-native' only checks the 'inputs' field of
> >> a package, not propagated-inputs.
> >
> > The attached patch should add the propagated inputs to the list of
> > inputs to check. Do we want to start telling it to ignore some of them?
>
> Wow, that was incredibly fast!
>
> > gnu/packages/check.scm:2200:2: python-nose-timer@0.7.5: 'python-nose'
> > should probably be a native input
>
> I'm inclined to leave it. I think many of these plugin packages should
> not be propagating the package that they plug into anyway.
>
> LGTM!
OK, patch pushed.
--
Efraim Flashner <address@hidden> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
signature.asc
Description: PGP signature