[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Bug#102437: dealloc analysis for each server function, more bugs!

From: Marcus Brinkmann
Subject: Bug#102437: dealloc analysis for each server function, more bugs!
Date: Thu, 12 Jul 2001 23:02:16 +0200
User-agent: Mutt/1.3.18i

On Thu, Jul 12, 2001 at 04:34:45PM -0400, Roland McGrath wrote:
> > On Wed, Jul 11, 2001 at 04:49:17PM -0400, Roland McGrath wrote:
> > > That's fine by me if it's tested.  BTW add -p to your diff switches.
> > 
> > Actually, I goofed up.  The arguments to the reply stub have not been
> > changed by my patch.  In fact, as we now copy the user data all the time, a
> > seperate reply stub is not necessary anymore!  There is also a bug
> > somewhere.
> > 
> > I will work out something better.
> I didn't look closely, but now I am thinking twice.  If the data is small
> enough to fit inline, and you use a separate reply stub, then you can send
> it without copying.  That ought to be the common case.

Yes, we can save one copy this way.  This is actually true in all
places where we return small amounts of data in an array.  It looks a bit
like micro-optimization, but I can do the change, null problemo.  It just
requires a different OUTIDS (idvec_copyout) function in
auth_server_authenticate, which sets *ids to user->ids.ids if the number
is small (and provides *ids and *n##ids to the reply stub).

Want me to do this?


`Rhubarb is no Egyptian god.' Debian http://www.debian.org brinkmd@debian.org
Marcus Brinkmann              GNU    http://www.gnu.org    marcus@gnu.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]