[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Bug#190732: [PATCH] hurd/libdiskfs/dir-renamed.c

From: Marcus Brinkmann
Subject: Bug#190732: [PATCH] hurd/libdiskfs/dir-renamed.c
Date: Tue, 15 Jul 2003 05:43:24 -0500
User-agent: Mutt/1.5.3i


I think the first patch is basically correct, although I wonder about
the following details:

1. What errors do you still expect from the second time diskfs_lookup is
invoked with REMOVE?  Is there any error that is allowed at that time?
If there is, the change is correct.

2. Is it possible, and according to diskfs.h it should be, to just
call dir_lookup with REMOVE only once, at the point you introduced it
in your patch, and store the dirstat until it is needed for the actual
disks_dirremove call.  This saves one lookup call.  Can you try such a
change and look into the code if it is feasible?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]