bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: The patch of glibc which allows the user to override the pfinet serv


From: Da Zheng
Subject: Re: The patch of glibc which allows the user to override the pfinet server
Date: Tue, 26 Aug 2008 12:53:20 +0200
User-agent: Thunderbird 2.0.0.16 (Macintosh/20080707)

olafBuddenhagen@gmx.net wrote:
       if (domain <= max_domain)
-      servers[domain] = server;
+       servers[domain] = server;
I'm not sure about this, but I think it is usually better to avoid
changing the indentation of code you haven't otherwise touched -- even
if it was wrong before...
As I remember, you asked me to fix the indentation problem...

I don't think so. IIRC you already changed the indentation in the first
variant of your patch, and I just pointed out that it is wrong after the
change -- which turned out to be because of your mail client mangling
it... I never meant to imply that it's right to change the indentation
of this line in the first place ;-)
Now look at what you said again, maybe I misunderstood:-)
Anyway, I'll fix it.

Zheng Da




reply via email to

[Prev in Thread] Current Thread [Next in Thread]