[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix --version in scripts

From: olafBuddenhagen
Subject: Re: [PATCH] Fix --version in scripts
Date: Wed, 26 May 2010 10:25:49 +0200
User-agent: Mutt/1.5.19 (2009-01-05)


On Tue, May 25, 2010 at 10:49:16AM +0200, Carl Fredrik Hammar wrote:

> Emilio reported that `fakeroot --version' (fakeroot-hurd in Debian)
> prints out `STANDARD_HURD_VERSION_uptime_' instead of its version. The
> bug is due to a faulty make rule which depends on the original sed
> script which inserted the correct version but was later inlined into
> Makeconf itself (back in '99!). The bug also affects uptime and
> mkfsimage.
> Here's a patch which fixes this, and the actual sed script.

Looks fine to me. Should be applied to master.

> P.S. This message should apply correctly with `git am -c'.

Don't do that. Just put your remarks below the "---" line. While they
will be passed to the patch command this way, "patch" ignores any junk
at the beginnig. (Like the diffstat included by default.)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]